Derive Point and Vector from Coordinates abstract class

[linpy.git] / pypol / domains.py

diff --git a/pypol/domains.py b/pypol/domains.py
index 44c38e7..3ab7d44 100644 (file)
--- a/pypol/domains.py
+++ b/pypol/domains.py
@@ -6,6 +6,7 @@ from fractions import Fraction
 
 from . import islhelper
 from .islhelper import mainctx, libisl, isl_set_basic_sets
+from .coordinates import Point
 from .linexprs import Expression, Symbol
 
 
@@ -265,41 +266,35 @@ class Domain:
         islbset = self._toislbasicset(self.equalities, self.inequalities, self.symbols)
         vertices = libisl.isl_basic_set_compute_vertices(islbset);
         vertices = islhelper.isl_vertices_vertices(vertices)
-        points = {}
-        num = 0
-        vertices_points = []
-        symbols = list(self.symbols)
+        points = []
         for vertex in vertices:
-            expr = libisl.isl_vertex_get_expr(vertex); #make vertices a bset
+            expr = libisl.isl_vertex_get_expr(vertex)
+            coordinates = []
             if islhelper.isl_version < '0.13':
-                constraints = islhelper.isl_basic_set_constraints(expr) #get bset constraints
-                for dim in symbols:
-                    index = symbols.index(dim)
-                    for c in constraints: #for each constraint 
-                        constant = libisl.isl_constraint_get_constant_val(c) #get contant value
-                        constant = islhelper.isl_val_to_int(constant)
-                        coefficient = libisl.isl_constraint_get_coefficient_val(c,libisl.isl_dim_set, index)
-                        coefficient = islhelper.isl_val_to_int(coefficient) #get coefficient
+                constraints = islhelper.isl_basic_set_constraints(expr)
+                for constraint in constraints:
+                    constant = libisl.isl_constraint_get_constant_val(constraint)
+                    constant = islhelper.isl_val_to_int(constant)
+                    for index, symbol in enumerate(self.symbols):
+                        coefficient = libisl.isl_constraint_get_coefficient_val(constraint,
+                            libisl.isl_dim_set, index)
+                        coefficient = islhelper.isl_val_to_int(coefficient)
                         if coefficient != 0:
-                            num = Fraction(constant, coefficient)
-                        points.update({dim:num})
-                vertices_points.append(points)
-                print(points)
-                    
+                            coordinate = -Fraction(constant, coefficient)
+                            coordinates.append((symbol, coordinate))
             else:
-                points = []
+                # horrible hack, find a cleaner solution
                 string = islhelper.isl_multi_aff_to_str(expr)
                 matches = self._RE_COORDINATE.finditer(string)
-                point = {}
                 for symbol, match in zip(self.symbols, matches):
                     numerator = int(match.group('num'))
                     denominator = match.group('den')
                     denominator = 1 if denominator is None else int(denominator)
                     coordinate = Fraction(numerator, denominator)
-                    point[symbol] = coordinate
-                points.append(point)
-        return vertices_points
-    
+                    coordinates.append((symbol, coordinate))
+            points.append(Point(coordinates))
+        return points
+
     def points(self):
         if not self.isbounded():
             raise ValueError('domain must be bounded')
@@ -308,13 +303,13 @@ class Domain:
         islpoints = islhelper.isl_set_points(islset)
         points = []
         for islpoint in islpoints:
-            point = {}
+            coordinates = {}
             for index, symbol in enumerate(self.symbols):
                 coordinate = libisl.isl_point_get_coordinate_val(islpoint,
                     libisl.isl_dim_set, index)
                 coordinate = islhelper.isl_val_to_int(coordinate)
-                point[symbol] = coordinate
-            points.append(point)
+                coordinates[symbol] = coordinate
+            points.append(Point(coordinates))
         return points
 
     def subs(self, symbol, expression=None):