Raise TypeError if Polyhedron.widen() is called on a non-polyhedral argument

[linpy.git] / linpy / polyhedra.py

diff --git a/linpy/polyhedra.py b/linpy/polyhedra.py
index 543e673..e5e2523 100644 (file)
--- a/linpy/polyhedra.py
+++ b/linpy/polyhedra.py
@@ -87,22 +87,20 @@ class Polyhedron(Domain):
             if inequalities is not None:
                 raise TypeError('too many arguments')
             return equalities.aspolyhedron()
             if inequalities is not None:
                 raise TypeError('too many arguments')
             return equalities.aspolyhedron()

-        if equalities is None:
-            equalities = []
-        else:
-            for i, equality in enumerate(equalities):
+        sc_equalities = []
+        if equalities is not None:
+            for equality in equalities:

                 if not isinstance(equality, LinExpr):
                     raise TypeError('equalities must be linear expressions')
                 if not isinstance(equality, LinExpr):
                     raise TypeError('equalities must be linear expressions')

-                equalities[i] = equality.scaleint()
-        if inequalities is None:
-            inequalities = []
-        else:
-            for i, inequality in enumerate(inequalities):
+                sc_equalities.append(equality.scaleint())
+        sc_inequalities = []
+        if inequalities is not None:
+            for inequality in inequalities:

                 if not isinstance(inequality, LinExpr):
                     raise TypeError('inequalities must be linear expressions')
                 if not isinstance(inequality, LinExpr):
                     raise TypeError('inequalities must be linear expressions')

-                inequalities[i] = inequality.scaleint()
-        symbols = cls._xsymbols(equalities + inequalities)
-        islbset = cls._toislbasicset(equalities, inequalities, symbols)
+                sc_inequalities.append(inequality.scaleint())
+        symbols = cls._xsymbols(sc_equalities + sc_inequalities)
+        islbset = cls._toislbasicset(sc_equalities, sc_inequalities, symbols)

         return cls._fromislbasicset(islbset, symbols)
 
     @property
         return cls._fromislbasicset(islbset, symbols)
 
     @property


@@ -175,9 +173,12 @@ class Polyhedron(Domain):
     def widen(self, other):
         """
         Compute the standard widening of two polyhedra, à la Halbwachs.
     def widen(self, other):
         """
         Compute the standard widening of two polyhedra, à la Halbwachs.

+
+        In its current implementation, this method is slow and should not be
+        used on large polyhedra.

         """
         if not isinstance(other, Polyhedron):
         """
         if not isinstance(other, Polyhedron):

-            raise ValueError('argument must be a Polyhedron instance')
+            raise TypeError('argument must be a Polyhedron instance')

         inequalities1 = self._asinequalities()
         inequalities2 = other._asinequalities()
         inequalities = []
         inequalities1 = self._asinequalities()
         inequalities2 = other._asinequalities()
         inequalities = []


@@ -305,8 +306,6 @@ class EmptyType(Polyhedron):
     The empty polyhedron, whose set of constraints is not satisfiable.
     """
 
     The empty polyhedron, whose set of constraints is not satisfiable.
     """
 

-    __slots__ = Polyhedron.__slots__
-

     def __new__(cls):
         self = object().__new__(cls)
         self._equalities = (Rational(1),)
     def __new__(cls):
         self = object().__new__(cls)
         self._equalities = (Rational(1),)


@@ -335,8 +334,6 @@ class UniverseType(Polyhedron):
     i.e. is empty.
     """
 
     i.e. is empty.
     """
 

-    __slots__ = Polyhedron.__slots__
-

     def __new__(cls):
         self = object().__new__(cls)
         self._equalities = ()
     def __new__(cls):
         self = object().__new__(cls)
         self._equalities = ()


@@ -402,15 +399,15 @@ def Ne(left, right):
     return ~Eq(left, right)
 
 @_polymorphic
     return ~Eq(left, right)
 
 @_polymorphic

-def Gt(left, right):
+def Ge(left, right):

     """
     """

-    Create the polyhedron with constraints expr1 > expr2 > expr3 ...
+    Create the polyhedron with constraints expr1 >= expr2 >= expr3 ...

     """
     """

-    return Polyhedron([], [left - right - 1])
+    return Polyhedron([], [left - right])

 
 @_polymorphic
 
 @_polymorphic

-def Ge(left, right):
+def Gt(left, right):

     """
     """

-    Create the polyhedron with constraints expr1 >= expr2 >= expr3 ...
+    Create the polyhedron with constraints expr1 > expr2 > expr3 ...

     """
     """

-    return Polyhedron([], [left - right])
+    return Polyhedron([], [left - right - 1])